fix: entrypoint honors one-off commands; ruff gate covers scripts/ #17

Merged

john merged 1 commit from fix/oneoff-cmds-and-scripts-lint into dev 2026-08-03 21:19:12 +00:00

Conversation 0 Commits 1 Files changed 2 +6 -2

haskos-bot commented 2026-08-03 20:40:29 +00:00

Owner

Copy link

Two operational fixes surfaced by the commitment-primitive rollout (2026-08-03).

1. dokku run <app> <cmd> silently boots a second uvicorn instead of running <cmd>. The entrypoint never consumed its arguments — migrations, then unconditional exec uvicorn. Seeding the commitment fixtures via dokku run produced exit 0, no output, and no effect. After migrations the entrypoint now exec "$@" when arguments are present; the no-args path (production boot, CI smoke test) is unchanged.

2. scripts/ was outside the ruff gate. CI linted app/ tests/ only — the exact blind spot PR #15's asyncpg bug lived in, and PR #16's seed script was only linted locally. Both ruff lines now include scripts/ (2 tracked files).

Deploy note: the entrypoint change only takes effect after the image redeploys — merging this PR triggers that deploy. Post-deploy check: dokku run haskos-finance echo ok should print ok.

Two operational fixes surfaced by the commitment-primitive rollout (2026-08-03). **1. `dokku run <app> <cmd>` silently boots a second uvicorn instead of running `<cmd>`.** The entrypoint never consumed its arguments — migrations, then unconditional `exec uvicorn`. Seeding the commitment fixtures via `dokku run` produced exit 0, no output, and no effect. After migrations the entrypoint now `exec "$@"` when arguments are present; the no-args path (production boot, CI smoke test) is unchanged. **2. `scripts/` was outside the ruff gate.** CI linted `app/ tests/` only — the exact blind spot PR #15's asyncpg bug lived in, and PR #16's seed script was only linted locally. Both ruff lines now include `scripts/` (2 tracked files). **Deploy note:** the entrypoint change only takes effect after the image redeploys — merging this PR triggers that deploy. Post-deploy check: `dokku run haskos-finance echo ok` should print `ok`.

haskos-bot added 1 commit 2026-08-03 20:40:29 +00:00

fix: entrypoint honors one-off commands; ruff gate covers scripts/ ... 1ead5f7b7a

dokku run <app> <cmd> silently booted a second uvicorn instead of running
<cmd> — the entrypoint never consumed its arguments. After migrations, exec
"$@" when arguments are present; otherwise start the server as before.

Also adds scripts/ to both ruff CI lines — the lint blind spot PR #15-class
bugs lived in (seed scripts were outside the gate).

john force-pushed fix/oneoff-cmds-and-scripts-lint from 1ead5f7b7a to 6b03132a92 2026-08-03 20:53:15 +00:00 Compare

john merged commit dc3b408eb7 into dev 2026-08-03 21:19:12 +00:00

john deleted branch fix/oneoff-cmds-and-scripts-lint 2026-08-03 21:19:12 +00:00

john referenced this pull request from a commit 2026-08-03 21:19:14 +00:00

Merge pull request 'fix: entrypoint honors one-off commands; ruff gate covers scripts/' (#17) from fix/oneoff-cmds-and-scripts-lint into dev

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

haskytech/haskos-finance!17

No description provided.